[Inventory] Use observability:entitycentricexperience to enable + side nav adjustments #193533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-dependency-from-observability-plugin
…ricexperience-to-enable-inventory-2
…ricexperience-to-enable-inventory-2
This reverts commit 2cd411f.
…nceSettingEnabled
…ricexperience-to-enable-inventory-2
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
iblancof
added
Team:obs-ux-infra_services
This reverts commit 3a0b5d7.
…ricexperience-to-enable-inventory-2
Bluefinger
reviewed
Sep 27, 2024
...plugins/observability_solution/inventory/public/components/inventory_page_template/index.tsx
Outdated
Show resolved
Hide resolved
…ricexperience-to-enable-inventory-2
…ricexperience-to-enable-inventory-2
|
Hello @roshan-elastic , During development, we discovered an area that we hadn't considered during refinement regarding space visibility management and roles. From what we observed, if we want to avoid conflicts with other space configurations, the new Inventory feature should appear in both the feature visibility configuration and role management settings. This means it will be visible in those areas (as shown in the screenshots) regardless of the value set in the Advanced Setting that currently controls its visibility (
Could you please confirm if this approach works for you? cc: @kpatticha @smith |
…ricexperience-to-enable-inventory-2
…ricexperience-to-enable-inventory-2
This looks like a great idea @iblancof. Let's do it! |
elena-shostak
approved these changes
Sep 27, 2024
…ricexperience-to-enable-inventory-2
…ricexperience-to-enable-inventory-2
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @iblancof |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11104400845 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
…e nav adjustments (elastic#193533) ## Summary Closes elastic#192323 and elastic#193393. ### Plugin enablement The enablement of the new Inventory plugin was previously managed via the `xpack.inventory.enabled` setting in kibana.yml. With this PR, we transition to enabling it through the `observability:entitycentricexperience` advanced setting. ### Position in side nav Additionally, this PR includes adjustments to the placement of the new Inventory page within the side navigation and the addition of the "Tech Preview" badge in the navigation where it was supported. |Navigation|Screenshot| |-|-| |Stateful classic (first nav)|| |Stateful classic (O11y)|| |Stateful new O11y|| |Serverless|| ### Global search A modification was made to the global search to prevent a duplicate result from appearing during searches by removing the deeplinks when registering the plugin. The UI changes are shown below. >[!WARNING] If this modification causes any other issues, please let me know in a comment. |With deeplink (before)|Without deeplink (after)| |-|-| ||| ### Services rename to Service Inventory Another needed change was to rename the nav item Services to Service Inventory >[!NOTE] Screenshots were taken before the navigation sorting was agreed with product, so the "Inventory" item does not appear in the right position. |Navigation|Screenshot| |-|-| |Stateful classic (O11y)|| |Stateful new O11y|| |Serverless|| >[!NOTE] The rename of infra Inventory to Infrastructure Inventory is being tracked separately in elastic#192324. ### Tech preview badge in page Lastly, the "Technical Preview" badge has been added to the page title. >[!NOTE] The screenshot was taken before the navigation sorting was agreed with product, so the "Inventory" item does not appear in the right position.  ### Plugin registration in server To make the Inventory available in the spaces and privileges configuration the plugin has been registered in the features service. >[!WARNING] I lack detailed context in this area, so I’ve added default empty configurations for most attributes. If any adjustments or improvements are needed, please let me know. |Space config|Privileges| |-|-| ||| --------- Co-authored-by: Kate Patticha <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 26f5e14)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
… + side nav adjustments (#193533) (#194408) # Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Use observability:entitycentricexperience to enable + side nav adjustments (#193533)](#193533) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T10:37:37Z","message":"[Inventory] Use observability:entitycentricexperience to enable + side nav adjustments (#193533)\n\n## Summary\r\n\r\nCloses #192323 and\r\nhttps://github.com//issues/193393.\r\n\r\n### Plugin enablement\r\nThe enablement of the new Inventory plugin was previously managed via\r\nthe `xpack.inventory.enabled` setting in kibana.yml. With this PR, we\r\ntransition to enabling it through the\r\n`observability:entitycentricexperience` advanced setting.\r\n\r\n\r\n### Position in side nav\r\nAdditionally, this PR includes adjustments to the placement of the new\r\nInventory page within the side navigation and the addition of the \"Tech\r\nPreview\" badge in the navigation where it was supported.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic (first nav)||\r\n|Stateful classic (O11y)||\r\n|Stateful new O11y||\r\n|Serverless||\r\n\r\n\r\n### Global search\r\nA modification was made to the global search to prevent a duplicate\r\nresult from appearing during searches by removing the deeplinks when\r\nregistering the plugin. The UI changes are shown below.\r\n\r\n>[!WARNING]\r\nIf this modification causes any other issues, please let me know in a\r\ncomment.\r\n\r\n|With deeplink (before)|Without deeplink (after)|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Services rename to Service Inventory\r\nAnother needed change was to rename the nav item Services to Service\r\nInventory\r\n\r\n>[!NOTE] \r\nScreenshots were taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic\r\n(O11y)||\r\n|Stateful new\r\nO11y||\r\n\r\n|Serverless||\r\n\r\n>[!NOTE] \r\nThe rename of infra Inventory to Infrastructure Inventory is being\r\ntracked separately in https://github.com/elastic/kibana/issues/192324.\r\n\r\n\r\n### Tech preview badge in page\r\nLastly, the \"Technical Preview\" badge has been added to the page title.\r\n\r\n>[!NOTE] \r\nThe screenshot was taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Plugin registration in server\r\nTo make the Inventory available in the spaces and privileges\r\nconfiguration the plugin has been registered in the features service.\r\n\r\n>[!WARNING]\r\nI lack detailed context in this area, so I’ve added default empty\r\nconfigurations for most attributes. If any adjustments or improvements\r\nare needed, please let me know.\r\n\r\n|Space config|Privileges|\r\n|-|-|\r\n|||\r\n\r\n---------\r\n\r\nCo-authored-by: Kate Patticha <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"26f5e1482b23548d1b06bec9e5fedf7dfa93a620","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.16.0"],"title":"[Inventory] Use observability:entitycentricexperience to enable + side nav adjustments","number":193533,"url":"https://github.com/elastic/kibana/pull/193533","mergeCommit":{"message":"[Inventory] Use observability:entitycentricexperience to enable + side nav adjustments (#193533)\n\n## Summary\r\n\r\nCloses #192323 and\r\nhttps://github.com//issues/193393.\r\n\r\n### Plugin enablement\r\nThe enablement of the new Inventory plugin was previously managed via\r\nthe `xpack.inventory.enabled` setting in kibana.yml. With this PR, we\r\ntransition to enabling it through the\r\n`observability:entitycentricexperience` advanced setting.\r\n\r\n\r\n### Position in side nav\r\nAdditionally, this PR includes adjustments to the placement of the new\r\nInventory page within the side navigation and the addition of the \"Tech\r\nPreview\" badge in the navigation where it was supported.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic (first nav)||\r\n|Stateful classic (O11y)||\r\n|Stateful new O11y||\r\n|Serverless||\r\n\r\n\r\n### Global search\r\nA modification was made to the global search to prevent a duplicate\r\nresult from appearing during searches by removing the deeplinks when\r\nregistering the plugin. The UI changes are shown below.\r\n\r\n>[!WARNING]\r\nIf this modification causes any other issues, please let me know in a\r\ncomment.\r\n\r\n|With deeplink (before)|Without deeplink (after)|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Services rename to Service Inventory\r\nAnother needed change was to rename the nav item Services to Service\r\nInventory\r\n\r\n>[!NOTE] \r\nScreenshots were taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic\r\n(O11y)||\r\n|Stateful new\r\nO11y||\r\n\r\n|Serverless||\r\n\r\n>[!NOTE] \r\nThe rename of infra Inventory to Infrastructure Inventory is being\r\ntracked separately in https://github.com/elastic/kibana/issues/192324.\r\n\r\n\r\n### Tech preview badge in page\r\nLastly, the \"Technical Preview\" badge has been added to the page title.\r\n\r\n>[!NOTE] \r\nThe screenshot was taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Plugin registration in server\r\nTo make the Inventory available in the spaces and privileges\r\nconfiguration the plugin has been registered in the features service.\r\n\r\n>[!WARNING]\r\nI lack detailed context in this area, so I’ve added default empty\r\nconfigurations for most attributes. If any adjustments or improvements\r\nare needed, please let me know.\r\n\r\n|Space config|Privileges|\r\n|-|-|\r\n|||\r\n\r\n---------\r\n\r\nCo-authored-by: Kate Patticha <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"26f5e1482b23548d1b06bec9e5fedf7dfa93a620"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193533","number":193533,"mergeCommit":{"message":"[Inventory] Use observability:entitycentricexperience to enable + side nav adjustments (#193533)\n\n## Summary\r\n\r\nCloses #192323 and\r\nhttps://github.com//issues/193393.\r\n\r\n### Plugin enablement\r\nThe enablement of the new Inventory plugin was previously managed via\r\nthe `xpack.inventory.enabled` setting in kibana.yml. With this PR, we\r\ntransition to enabling it through the\r\n`observability:entitycentricexperience` advanced setting.\r\n\r\n\r\n### Position in side nav\r\nAdditionally, this PR includes adjustments to the placement of the new\r\nInventory page within the side navigation and the addition of the \"Tech\r\nPreview\" badge in the navigation where it was supported.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic (first nav)||\r\n|Stateful classic (O11y)||\r\n|Stateful new O11y||\r\n|Serverless||\r\n\r\n\r\n### Global search\r\nA modification was made to the global search to prevent a duplicate\r\nresult from appearing during searches by removing the deeplinks when\r\nregistering the plugin. The UI changes are shown below.\r\n\r\n>[!WARNING]\r\nIf this modification causes any other issues, please let me know in a\r\ncomment.\r\n\r\n|With deeplink (before)|Without deeplink (after)|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Services rename to Service Inventory\r\nAnother needed change was to rename the nav item Services to Service\r\nInventory\r\n\r\n>[!NOTE] \r\nScreenshots were taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic\r\n(O11y)||\r\n|Stateful new\r\nO11y||\r\n\r\n|Serverless||\r\n\r\n>[!NOTE] \r\nThe rename of infra Inventory to Infrastructure Inventory is being\r\ntracked separately in https://github.com/elastic/kibana/issues/192324.\r\n\r\n\r\n### Tech preview badge in page\r\nLastly, the \"Technical Preview\" badge has been added to the page title.\r\n\r\n>[!NOTE] \r\nThe screenshot was taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Plugin registration in server\r\nTo make the Inventory available in the spaces and privileges\r\nconfiguration the plugin has been registered in the features service.\r\n\r\n>[!WARNING]\r\nI lack detailed context in this area, so I’ve added default empty\r\nconfigurations for most attributes. If any adjustments or improvements\r\nare needed, please let me know.\r\n\r\n|Space config|Privileges|\r\n|-|-|\r\n|||\r\n\r\n---------\r\n\r\nCo-authored-by: Kate Patticha <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"26f5e1482b23548d1b06bec9e5fedf7dfa93a620"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <[email protected]>
iblancof
deleted the
192323-inventory-use-observabilityentitycentricexperience-to-enable-inventory-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #192323 and #193393.
Plugin enablement
The enablement of the new Inventory plugin was previously managed via the
xpack.inventory.enabledsetting in kibana.yml. With this PR, we transition to enabling it through theobservability:entitycentricexperienceadvanced setting.Position in side nav
Additionally, this PR includes adjustments to the placement of the new Inventory page within the side navigation and the addition of the "Tech Preview" badge in the navigation where it was supported.
Global search
A modification was made to the global search to prevent a duplicate result from appearing during searches by removing the deeplinks when registering the plugin. The UI changes are shown below.
Warning
If this modification causes any other issues, please let me know in a comment.
Services rename to Service Inventory
Another needed change was to rename the nav item Services to Service Inventory
Note
Screenshots were taken before the navigation sorting was agreed with product, so the "Inventory" item does not appear in the right position.
Note
The rename of infra Inventory to Infrastructure Inventory is being tracked separately in #192324.
Tech preview badge in page
Lastly, the "Technical Preview" badge has been added to the page title.
Note
The screenshot was taken before the navigation sorting was agreed with product, so the "Inventory" item does not appear in the right position.
Plugin registration in server
To make the Inventory available in the spaces and privileges configuration the plugin has been registered in the features service.
Warning
I lack detailed context in this area, so I’ve added default empty configurations for most attributes. If any adjustments or improvements are needed, please let me know.